Skip to content

RTF: Fix TextBreak.php #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

RTF: Fix TextBreak.php #2816

wants to merge 4 commits into from

Conversation

rasamassen
Copy link

@rasamassen rasamassen commented Sep 1, 2025 •
edited
Loading

Returns line return instead of paragraph return on textrun, footnote, and endnote.

Description

TextBreak was always creating a new paragraph, even when it should have just been making a line break.

Fixes # (issue)

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@rasamassen
Fix TextBreak.php
2ac2369 
Returns line return instead of paragraph return on textrun, footnote, and endnote.
@rasamassen rasamassen changed the title Fix TextBreak.php RTF: Fix TextBreak.php Sep 1, 2025
@coveralls
Copy link

coveralls commented Sep 1, 2025 •
edited
Loading

Coverage Status

coverage: 96.757%. remained the same
when pulling 6a28762 on rasamassen:TextBreak
into 0ab0b49 on PHPOffice:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasamassen @coveralls